From 23efcab80c069db81a85f1f4d66c561a0379ffb6 Mon Sep 17 00:00:00 2001
From: ianshaloom <naimoolsha@gmail.com>
Date: Sun, 8 Mar 2026 00:45:57 +0300
Subject: [PATCH] fix: resolve CI and workspace lint errors (admin +
 storefront)

- Allow require() in next.config.js (eslint-disable) for both apps
- Replace all catch (e: any) with catch (e: unknown) and proper error handling
- Remove no-explicit-any: add types (PreviewProduct, ProductImage, Id<addresses>,
  ProductDetailReview, error payloads) across admin and storefront
- Admin: use next/image in ImageUploadSection and ProductImageCarousel; remove
  unused layout fonts and sidebar imports; fix products page useMemo deps
- Storefront: use Link for /sign-in in header actions; fix useAddressMutations
  and product detail types; remove unused imports/vars and fix useMemo deps

Made-with: Cursor
---
 apps/admin/next.config.js                     |  1 +
 .../admin/src/app/(dashboard)/images/page.tsx |  7 +++--
 .../(dashboard)/products/[id]/edit/page.tsx   |  8 +++---
 .../src/app/(dashboard)/products/new/page.tsx |  4 +--
 .../src/app/(dashboard)/products/page.tsx     | 13 +++++----
 apps/admin/src/app/layout.tsx                 | 14 ++--------
 .../components/images/ImageUploadSection.tsx  | 27 ++++++++++++-------
 .../images/ProductImageCarousel.tsx           | 10 ++++---
 .../images/ProductSearchSection.tsx           |  2 +-
 .../components/layout/sidebar/app-sidebar.tsx |  2 --
 .../orders/actions/AcceptReturnButton.tsx     |  4 +--
 .../orders/actions/CreateLabelButton.tsx      |  4 +--
 .../orders/actions/IssueRefundButton.tsx      |  4 +--
 .../actions/MarkReturnReceivedButton.tsx      |  4 +--
 .../orders/actions/UpdateStatusDialog.tsx     |  4 +--
 .../shared/ProductSearchSection.tsx           |  2 +-
 .../variants/CreateVariantDialog.tsx          |  4 +--
 .../components/variants/EditVariantDialog.tsx |  4 +--
 .../src/components/variants/VariantsTable.tsx |  8 +++---
 apps/storefront/next.config.js                |  1 +
 .../checkout/content/AddressSelector.tsx      |  2 +-
 .../header/desktop/HeaderUserAction.tsx       |  5 ++--
 .../header/mobile/MobileHeaderUserAction.tsx  |  5 ++--
 .../reviews/ProductDetailReviewsPanel.tsx     |  4 +--
 .../sections/ProductDetailHeroSection.tsx     |  5 +++-
 .../ProductDetailHeroSectionWrapper.tsx       |  2 +-
 .../sections/ProductDetailSectionsWrapper.tsx |  1 -
 .../src/components/shop/ShopFilterContent.tsx | 10 -------
 .../src/components/shop/ShopFilterSidebar.tsx |  1 -
 .../src/components/shop/ShopToolbar.tsx       |  1 -
 .../components/wishlist/WishlistPageView.tsx  |  3 +--
 .../wishlist/state/WishlistEmptyState.tsx     |  1 -
 .../src/lib/checkout/useAddressMutations.ts   |  7 ++---
 .../src/lib/search/useClickOutside.test.tsx   |  2 +-
 34 files changed, 87 insertions(+), 89 deletions(-)

diff --git a/apps/admin/next.config.js b/apps/admin/next.config.js
index 77df6d7..5155e0c 100644
--- a/apps/admin/next.config.js
+++ b/apps/admin/next.config.js
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-require-imports -- Next.js config commonly uses require */
 const path = require("path");
 
 /** @type {import('next').NextConfig} */
diff --git a/apps/admin/src/app/(dashboard)/images/page.tsx b/apps/admin/src/app/(dashboard)/images/page.tsx
index 3c301fb..6e70e79 100644
--- a/apps/admin/src/app/(dashboard)/images/page.tsx
+++ b/apps/admin/src/app/(dashboard)/images/page.tsx
@@ -5,7 +5,10 @@ import { useQuery } from "convex/react"
 import { api } from "../../../../../../convex/_generated/api"
 import type { Id } from "../../../../../../convex/_generated/dataModel"
 import { ProductSearchSection } from "../../../components/shared/ProductSearchSection"
-import { ProductImageCarousel } from "../../../components/images/ProductImageCarousel"
+import {
+  ProductImageCarousel,
+  type ProductImage,
+} from "../../../components/images/ProductImageCarousel"
 import { ImageUploadSection } from "../../../components/images/ImageUploadSection"
 import { Skeleton } from "@/components/ui/skeleton"
 import { Separator } from "@/components/ui/separator"
@@ -79,7 +82,7 @@ export default function ImagesPage() {
               </div>
             ) : (
               <ProductImageCarousel
-                images={images as any}
+                images={images as ProductImage[]}
                 onAddMore={() => setShowUpload(true)}
               />
             )}
diff --git a/apps/admin/src/app/(dashboard)/products/[id]/edit/page.tsx b/apps/admin/src/app/(dashboard)/products/[id]/edit/page.tsx
index 08affc5..e063890 100644
--- a/apps/admin/src/app/(dashboard)/products/[id]/edit/page.tsx
+++ b/apps/admin/src/app/(dashboard)/products/[id]/edit/page.tsx
@@ -53,8 +53,8 @@ export default function EditProductPage() {
         categoryId: payload.categoryId as Id<"categories">,
       })
       router.push("/products")
-    } catch (e: any) {
-      setError(e?.message ?? "Failed to save product. Please try again.")
+    } catch (e: unknown) {
+      setError(e instanceof Error ? e.message : "Failed to save product. Please try again.")
       setIsSubmitting(false)
     }
   }
@@ -64,8 +64,8 @@ export default function EditProductPage() {
     try {
       await archiveProduct({ id: productId })
       router.push("/products")
-    } catch (e: any) {
-      setError(e?.message ?? "Failed to archive product.")
+    } catch (e: unknown) {
+      setError(e instanceof Error ? e.message : "Failed to archive product.")
       setIsArchiving(false)
     }
   }
diff --git a/apps/admin/src/app/(dashboard)/products/new/page.tsx b/apps/admin/src/app/(dashboard)/products/new/page.tsx
index c52eeb0..166e184 100644
--- a/apps/admin/src/app/(dashboard)/products/new/page.tsx
+++ b/apps/admin/src/app/(dashboard)/products/new/page.tsx
@@ -33,8 +33,8 @@ export default function NewProductPage() {
         categoryId: payload.categoryId as Id<"categories">,
       })
       router.push("/products")
-    } catch (e: any) {
-      setError(e?.message ?? "Failed to create product. Please try again.")
+    } catch (e: unknown) {
+      setError(e instanceof Error ? e.message : "Failed to create product. Please try again.")
       setIsSubmitting(false)
     }
   }
diff --git a/apps/admin/src/app/(dashboard)/products/page.tsx b/apps/admin/src/app/(dashboard)/products/page.tsx
index 7d9584b..80de090 100644
--- a/apps/admin/src/app/(dashboard)/products/page.tsx
+++ b/apps/admin/src/app/(dashboard)/products/page.tsx
@@ -199,11 +199,14 @@ export default function ProductsPage() {
     ? searchResults === undefined
     : listStatus === "LoadingFirstPage"
 
-  const rawProducts = isSearching ? (searchResults ?? []) : listResults
+  const rawProducts = useMemo(
+    () => (isSearching ? (searchResults ?? []) : listResults),
+    [isSearching, searchResults, listResults],
+  )
 
   const products = useMemo(() => {
     if (!sortField) return rawProducts
-    return [...rawProducts].sort((a: any, b: any) => {
+    return [...rawProducts].sort((a: PreviewProduct, b: PreviewProduct) => {
       const aVal: string =
         sortField === "name"
           ? (a.name ?? "")
@@ -235,8 +238,8 @@ export default function ProductsPage() {
     setVisibleCols((prev) => ({ ...prev, [key]: checked }))
   }
 
-  function openPreview(product: any) {
-    setPreviewProduct(product as PreviewProduct)
+  function openPreview(product: PreviewProduct) {
+    setPreviewProduct(product)
     setPreviewOpen(true)
   }
 
@@ -374,7 +377,7 @@ export default function ProductsPage() {
                 </TableCell>
               </TableRow>
             ) : (
-              products.map((product: any) => {
+              products.map((product: PreviewProduct) => {
                 const statusCfg =
                   STATUS_CONFIG[product.status as keyof typeof STATUS_CONFIG]
                 return (
diff --git a/apps/admin/src/app/layout.tsx b/apps/admin/src/app/layout.tsx
index aef44ec..bde81e9 100644
--- a/apps/admin/src/app/layout.tsx
+++ b/apps/admin/src/app/layout.tsx
@@ -1,21 +1,11 @@
 import type { Metadata } from "next";
-import { DM_Sans, Geist, Geist_Mono } from "next/font/google";
+import { DM_Sans } from "next/font/google";
 import { ClerkProvider } from "@clerk/nextjs";
 import { ConvexClientProvider } from "@repo/convex";
 import { Toaster } from "sonner";
 import "./globals.css";
 
-const dmSans = DM_Sans({subsets:['latin'],variable:'--font-sans'});
-
-const geistSans = Geist({
-  variable: "--font-geist-sans",
-  subsets: ["latin"],
-});
-
-const geistMono = Geist_Mono({
-  variable: "--font-geist-mono",
-  subsets: ["latin"],
-});
+const dmSans = DM_Sans({ subsets: ["latin"], variable: "--font-sans" });
 
 export const metadata: Metadata = {
   title: {
diff --git a/apps/admin/src/components/images/ImageUploadSection.tsx b/apps/admin/src/components/images/ImageUploadSection.tsx
index fb7a528..8e51939 100644
--- a/apps/admin/src/components/images/ImageUploadSection.tsx
+++ b/apps/admin/src/components/images/ImageUploadSection.tsx
@@ -1,6 +1,7 @@
 "use client"
 
 import { useState, useRef } from "react"
+import Image from "next/image"
 import { useMutation } from "convex/react"
 import { api } from "../../../../../convex/_generated/api"
 import type { Id } from "../../../../../convex/_generated/dataModel"
@@ -61,8 +62,8 @@ export function ImageUploadSection({
       })
 
       if (!res.ok) {
-        const errJson = await res.json().catch(() => ({}))
-        throw new Error((errJson as any).detail ?? "Background removal failed")
+        const errJson = (await res.json().catch(() => ({}))) as { detail?: string }
+        throw new Error(errJson.detail ?? "Background removal failed")
       }
 
       const blob = await res.blob()
@@ -100,8 +101,8 @@ export function ImageUploadSection({
     })
 
     if (!uploadRes.ok) {
-      const errJson = await uploadRes.json().catch(() => ({}))
-      throw new Error((errJson as any).error ?? "Upload failed")
+      const errJson = (await uploadRes.json().catch(() => ({}))) as { error?: string }
+      throw new Error(errJson.error ?? "Upload failed")
     }
 
     const { url } = await uploadRes.json()
@@ -188,8 +189,14 @@ export function ImageUploadSection({
           <div className="space-y-1">
             <p className="text-xs font-medium text-muted-foreground">Original</p>
             {localUrl && (
-              <div className="aspect-square overflow-hidden rounded-md border bg-muted">
-                <img src={localUrl} alt="Original" className="h-full w-full object-contain" />
+              <div className="relative aspect-square overflow-hidden rounded-md border bg-muted">
+                <Image
+                  src={localUrl}
+                  alt="Original"
+                  fill
+                  className="object-contain"
+                  unoptimized
+                />
               </div>
             )}
           </div>
@@ -199,11 +206,13 @@ export function ImageUploadSection({
             {isProcessing ? (
               <Skeleton className="aspect-square w-full rounded-md" />
             ) : processedUrl ? (
-              <div className="aspect-square overflow-hidden rounded-md border bg-[conic-gradient(#e5e7eb_25%,_#fff_25%,_#fff_50%,_#e5e7eb_50%,_#e5e7eb_75%,_#fff_75%)] bg-[length:16px_16px]">
-                <img
+              <div className="relative aspect-square overflow-hidden rounded-md border bg-[conic-gradient(#e5e7eb_25%,_#fff_25%,_#fff_50%,_#e5e7eb_50%,_#e5e7eb_75%,_#fff_75%)] bg-[length:16px_16px]">
+                <Image
                   src={processedUrl}
                   alt="Background removed"
-                  className="h-full w-full object-contain"
+                  fill
+                  className="object-contain"
+                  unoptimized
                 />
               </div>
             ) : processingError ? (
diff --git a/apps/admin/src/components/images/ProductImageCarousel.tsx b/apps/admin/src/components/images/ProductImageCarousel.tsx
index 644328b..925b28d 100644
--- a/apps/admin/src/components/images/ProductImageCarousel.tsx
+++ b/apps/admin/src/components/images/ProductImageCarousel.tsx
@@ -1,6 +1,7 @@
 "use client"
 
 import { useState, useEffect } from "react"
+import Image from "next/image"
 import {
   DndContext,
   closestCenter,
@@ -35,7 +36,7 @@ import { Button } from "@/components/ui/button"
 import { HugeiconsIcon } from "@hugeicons/react"
 import { Delete02Icon, ImageAdd01Icon, DragDropVerticalIcon } from "@hugeicons/core-free-icons"
 
-interface ProductImage {
+export interface ProductImage {
   _id: Id<"productImages">
   url: string
   alt?: string
@@ -105,11 +106,12 @@ function SortableImageCard({
 
         {/* Row 2 in DOM → Row 2 visually (middle stays middle) */}
         {/* Image — appears in CENTER */}
-        <div className="w-28 aspect-square rotate-180 overflow-hidden rounded-md border bg-muted">
-          <img
+        <div className="relative w-28 aspect-square rotate-180 overflow-hidden rounded-md border bg-muted">
+          <Image
             src={image.url}
             alt={image.alt ?? "Product image"}
-            className="h-full w-full object-contain"
+            fill
+            className="object-contain"
           />
         </div>
 
diff --git a/apps/admin/src/components/images/ProductSearchSection.tsx b/apps/admin/src/components/images/ProductSearchSection.tsx
index 415d31c..6f57aaa 100644
--- a/apps/admin/src/components/images/ProductSearchSection.tsx
+++ b/apps/admin/src/components/images/ProductSearchSection.tsx
@@ -84,7 +84,7 @@ export function ProductSearchSection({ onSelect, onClear, selectedId }: ProductS
 
       {!isLoading && results && results.length > 0 && (
         <ul className="max-w-sm divide-y rounded-md border">
-          {results.map((product: any) => (
+          {results.map((product: { _id: string; name: string }) => (
             <li key={product._id}>
               <button
                 type="button"
diff --git a/apps/admin/src/components/layout/sidebar/app-sidebar.tsx b/apps/admin/src/components/layout/sidebar/app-sidebar.tsx
index 38198b6..e1b265e 100644
--- a/apps/admin/src/components/layout/sidebar/app-sidebar.tsx
+++ b/apps/admin/src/components/layout/sidebar/app-sidebar.tsx
@@ -1,8 +1,6 @@
 "use client";
 
 import * as React from "react";
-import { HugeiconsIcon } from "@hugeicons/react";
-import { Store01Icon } from "@hugeicons/core-free-icons";
 import {
   Sidebar,
   SidebarContent,
diff --git a/apps/admin/src/components/orders/actions/AcceptReturnButton.tsx b/apps/admin/src/components/orders/actions/AcceptReturnButton.tsx
index b18b8cb..5abd46e 100644
--- a/apps/admin/src/components/orders/actions/AcceptReturnButton.tsx
+++ b/apps/admin/src/components/orders/actions/AcceptReturnButton.tsx
@@ -24,8 +24,8 @@ export function AcceptReturnButton({ orderId }: Props) {
       } else {
         toast.error((result as { success: false; code: string; message: string }).message)
       }
-    } catch (e: any) {
-      toast.error(e?.message ?? "Failed to accept return.")
+    } catch (e: unknown) {
+      toast.error(e instanceof Error ? e.message : "Failed to accept return.")
     } finally {
       setIsLoading(false)
     }
diff --git a/apps/admin/src/components/orders/actions/CreateLabelButton.tsx b/apps/admin/src/components/orders/actions/CreateLabelButton.tsx
index a79957d..1491ec2 100644
--- a/apps/admin/src/components/orders/actions/CreateLabelButton.tsx
+++ b/apps/admin/src/components/orders/actions/CreateLabelButton.tsx
@@ -24,8 +24,8 @@ export function CreateLabelButton({ orderId }: Props) {
       } else {
         toast.error((result as { success: false; code: string; message: string }).message)
       }
-    } catch (e: any) {
-      toast.error(e?.message ?? "Failed to create shipping label.")
+    } catch (e: unknown) {
+      toast.error(e instanceof Error ? e.message : "Failed to create shipping label.")
     } finally {
       setIsLoading(false)
     }
diff --git a/apps/admin/src/components/orders/actions/IssueRefundButton.tsx b/apps/admin/src/components/orders/actions/IssueRefundButton.tsx
index 11a7fbe..d252d40 100644
--- a/apps/admin/src/components/orders/actions/IssueRefundButton.tsx
+++ b/apps/admin/src/components/orders/actions/IssueRefundButton.tsx
@@ -37,8 +37,8 @@ export function IssueRefundButton({ orderId, total, currency }: Props) {
       await issueRefund({ orderId })
       toast.success("Refund issued.")
       setOpen(false)
-    } catch (e: any) {
-      toast.error(e?.message ?? "Failed to issue refund.")
+    } catch (e: unknown) {
+      toast.error(e instanceof Error ? e.message : "Failed to issue refund.")
     } finally {
       setIsLoading(false)
     }
diff --git a/apps/admin/src/components/orders/actions/MarkReturnReceivedButton.tsx b/apps/admin/src/components/orders/actions/MarkReturnReceivedButton.tsx
index 3247319..70fd4c4 100644
--- a/apps/admin/src/components/orders/actions/MarkReturnReceivedButton.tsx
+++ b/apps/admin/src/components/orders/actions/MarkReturnReceivedButton.tsx
@@ -32,8 +32,8 @@ export function MarkReturnReceivedButton({ orderId }: Props) {
       await markReceived({ id: orderId })
       toast.success("Return marked as received.")
       setOpen(false)
-    } catch (e: any) {
-      toast.error(e?.message ?? "Failed to mark return as received.")
+    } catch (e: unknown) {
+      toast.error(e instanceof Error ? e.message : "Failed to mark return as received.")
     } finally {
       setIsLoading(false)
     }
diff --git a/apps/admin/src/components/orders/actions/UpdateStatusDialog.tsx b/apps/admin/src/components/orders/actions/UpdateStatusDialog.tsx
index ddad29c..9d48399 100644
--- a/apps/admin/src/components/orders/actions/UpdateStatusDialog.tsx
+++ b/apps/admin/src/components/orders/actions/UpdateStatusDialog.tsx
@@ -62,8 +62,8 @@ export function UpdateStatusDialog({ orderId, currentStatus }: Props) {
       const label = ORDER_STATUS_CONFIG[selectedStatus as OrderStatus]?.label
       toast.success(`Status updated to ${label ?? selectedStatus}`)
       setOpen(false)
-    } catch (e: any) {
-      toast.error(e?.message ?? "Failed to update status.")
+    } catch (e: unknown) {
+      toast.error(e instanceof Error ? e.message : "Failed to update status.")
     } finally {
       setIsSubmitting(false)
     }
diff --git a/apps/admin/src/components/shared/ProductSearchSection.tsx b/apps/admin/src/components/shared/ProductSearchSection.tsx
index d0ba3bf..6ed4530 100644
--- a/apps/admin/src/components/shared/ProductSearchSection.tsx
+++ b/apps/admin/src/components/shared/ProductSearchSection.tsx
@@ -84,7 +84,7 @@ export function ProductSearchSection({ onSelect, onClear, selectedId }: ProductS
 
       {!isLoading && results && results.length > 0 && (
         <ul className="max-w-sm divide-y rounded-md border">
-          {results.map((product: any) => (
+          {results.map((product: { _id: string; name: string }) => (
             <li key={product._id}>
               <button
                 type="button"
diff --git a/apps/admin/src/components/variants/CreateVariantDialog.tsx b/apps/admin/src/components/variants/CreateVariantDialog.tsx
index 8b86681..cf3b80f 100644
--- a/apps/admin/src/components/variants/CreateVariantDialog.tsx
+++ b/apps/admin/src/components/variants/CreateVariantDialog.tsx
@@ -68,8 +68,8 @@ export function CreateVariantDialog({
 
       toast.success(`Variant "${values.name}" created`)
       onOpenChange(false)
-    } catch (e: any) {
-      toast.error(e?.message ?? "Failed to create variant")
+    } catch (e: unknown) {
+      toast.error(e instanceof Error ? e.message : "Failed to create variant")
     } finally {
       setIsSubmitting(false)
     }
diff --git a/apps/admin/src/components/variants/EditVariantDialog.tsx b/apps/admin/src/components/variants/EditVariantDialog.tsx
index fa5bdb9..e64ebc5 100644
--- a/apps/admin/src/components/variants/EditVariantDialog.tsx
+++ b/apps/admin/src/components/variants/EditVariantDialog.tsx
@@ -69,8 +69,8 @@ export function EditVariantDialog({
 
       toast.success(`"${values.name}" updated`)
       onOpenChange(false)
-    } catch (e: any) {
-      toast.error(e?.message ?? "Failed to update variant")
+    } catch (e: unknown) {
+      toast.error(e instanceof Error ? e.message : "Failed to update variant")
     } finally {
       setIsSubmitting(false)
     }
diff --git a/apps/admin/src/components/variants/VariantsTable.tsx b/apps/admin/src/components/variants/VariantsTable.tsx
index 2b08e55..c925cf4 100644
--- a/apps/admin/src/components/variants/VariantsTable.tsx
+++ b/apps/admin/src/components/variants/VariantsTable.tsx
@@ -103,8 +103,8 @@ function VariantActionsMenu({
     try {
       await updateVariant({ id: variant._id, isActive: !variant.isActive })
       toast.success(`"${variant.name}" ${variant.isActive ? "deactivated" : "activated"}`)
-    } catch (e: any) {
-      toast.error(e?.message ?? "Failed to update variant")
+    } catch (e: unknown) {
+      toast.error(e instanceof Error ? e.message : "Failed to update variant")
     } finally {
       setIsToggling(false)
     }
@@ -116,8 +116,8 @@ function VariantActionsMenu({
       await deleteVariant({ id: variant._id })
       toast.success(`"${variant.name}" deleted`)
       setDeleteOpen(false)
-    } catch (e: any) {
-      toast.error(e?.message ?? "Failed to delete variant")
+    } catch (e: unknown) {
+      toast.error(e instanceof Error ? e.message : "Failed to delete variant")
     } finally {
       setIsDeleting(false)
     }
diff --git a/apps/storefront/next.config.js b/apps/storefront/next.config.js
index 30bbef1..763c3e5 100644
--- a/apps/storefront/next.config.js
+++ b/apps/storefront/next.config.js
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-require-imports -- Next.js config commonly uses require */
 const path = require("path");
 
 /** @type {import('next').NextConfig} */
diff --git a/apps/storefront/src/components/checkout/content/AddressSelector.tsx b/apps/storefront/src/components/checkout/content/AddressSelector.tsx
index 11cc05c..4547f27 100644
--- a/apps/storefront/src/components/checkout/content/AddressSelector.tsx
+++ b/apps/storefront/src/components/checkout/content/AddressSelector.tsx
@@ -1,6 +1,6 @@
 "use client";
 
-import { Button, Chip, RadioGroup, Radio, Label, Skeleton } from "@heroui/react";
+import { Button, Chip, RadioGroup, Radio, Skeleton } from "@heroui/react";
 import type { CheckoutAddress } from "@/lib/checkout/types";
 
 type AddressSelectorProps = {
diff --git a/apps/storefront/src/components/layout/header/desktop/HeaderUserAction.tsx b/apps/storefront/src/components/layout/header/desktop/HeaderUserAction.tsx
index 38475b2..79a2103 100644
--- a/apps/storefront/src/components/layout/header/desktop/HeaderUserAction.tsx
+++ b/apps/storefront/src/components/layout/header/desktop/HeaderUserAction.tsx
@@ -1,5 +1,6 @@
 "use client";
 
+import Link from "next/link";
 import { useConvexAuth } from "convex/react";
 import { UserButton } from "@clerk/nextjs";
 
@@ -27,7 +28,7 @@ export function HeaderUserAction() {
 
   if (isLoading || !isAuthenticated) {
     return (
-      <a
+      <Link
         href="/sign-in"
         className="group flex flex-col items-center gap-1"
       >
@@ -48,7 +49,7 @@ export function HeaderUserAction() {
         <span className="text-[10px] font-medium tracking-wide text-[#3d5554] transition-colors group-hover:text-[#236f6b]">
           Sign In
         </span>
-      </a>
+      </Link>
     );
   }
 
diff --git a/apps/storefront/src/components/layout/header/mobile/MobileHeaderUserAction.tsx b/apps/storefront/src/components/layout/header/mobile/MobileHeaderUserAction.tsx
index a1cf539..48d850b 100644
--- a/apps/storefront/src/components/layout/header/mobile/MobileHeaderUserAction.tsx
+++ b/apps/storefront/src/components/layout/header/mobile/MobileHeaderUserAction.tsx
@@ -1,5 +1,6 @@
 "use client";
 
+import Link from "next/link";
 import { useConvexAuth } from "convex/react";
 import { UserButton } from "@clerk/nextjs";
 
@@ -27,7 +28,7 @@ export function MobileHeaderUserAction() {
 
   if (isLoading || !isAuthenticated) {
     return (
-      <a
+      <Link
         href="/sign-in"
         className="flex h-8 w-8 items-center justify-center rounded-full border border-[#d9e8e7] bg-[#f9fcfb]"
       >
@@ -45,7 +46,7 @@ export function MobileHeaderUserAction() {
           <path d="M20 21v-2a4 4 0 0 0-4-4H8a4 4 0 0 0-4 4v2" />
           <circle cx="12" cy="7" r="4" />
         </svg>
-      </a>
+      </Link>
     );
   }
 
diff --git a/apps/storefront/src/components/product-detail/reviews/ProductDetailReviewsPanel.tsx b/apps/storefront/src/components/product-detail/reviews/ProductDetailReviewsPanel.tsx
index 2963b81..956f902 100644
--- a/apps/storefront/src/components/product-detail/reviews/ProductDetailReviewsPanel.tsx
+++ b/apps/storefront/src/components/product-detail/reviews/ProductDetailReviewsPanel.tsx
@@ -4,7 +4,7 @@ import { useState } from "react";
 import { useQuery } from "convex/react";
 import { api } from "../../../../../../convex/_generated/api";
 import type { Id } from "../../../../../../convex/_generated/dataModel";
-import { ReviewSortOption } from "@/lib/product-detail/types";
+import type { ProductDetailReview, ReviewSortOption } from "@/lib/product-detail/types";
 import { ReviewSortBar } from "./ReviewSortBar";
 import { ReviewList } from "./ReviewList";
 import { ReviewForm } from "./ReviewForm";
@@ -58,7 +58,7 @@ export function ProductDetailReviewsPanel({ productId, initialRating, initialRev
                         onSortChange={handleSortChange}
                     />
                     <ReviewList
-                        reviews={page as any}
+                        reviews={page as ProductDetailReview[]}
                         total={total}
                         hasMore={hasMore}
                         isLoading={result === undefined}
diff --git a/apps/storefront/src/components/product-detail/sections/ProductDetailHeroSection.tsx b/apps/storefront/src/components/product-detail/sections/ProductDetailHeroSection.tsx
index 67c9dce..d4e6dcd 100644
--- a/apps/storefront/src/components/product-detail/sections/ProductDetailHeroSection.tsx
+++ b/apps/storefront/src/components/product-detail/sections/ProductDetailHeroSection.tsx
@@ -206,7 +206,10 @@ export function ProductDetailHeroSection({
   const [addError, setAddError] = useState<string | null>(null);
 
   const images: ProductDetailImage[] = product.images ?? [];
-  const variants: ProductDetailVariant[] = product.variants ?? [];
+  const variants = useMemo(
+    () => (product.variants ?? []) as ProductDetailVariant[],
+    [product.variants],
+  );
   const mainImage = images[selectedImageIndex] ?? images[0];
   const dimensions = useMemo(
     () => getAttributeDimensions(variants),
diff --git a/apps/storefront/src/components/product-detail/sections/ProductDetailHeroSectionWrapper.tsx b/apps/storefront/src/components/product-detail/sections/ProductDetailHeroSectionWrapper.tsx
index 9c12320..56cca73 100644
--- a/apps/storefront/src/components/product-detail/sections/ProductDetailHeroSectionWrapper.tsx
+++ b/apps/storefront/src/components/product-detail/sections/ProductDetailHeroSectionWrapper.tsx
@@ -23,7 +23,7 @@ export async function ProductDetailHeroSectionWrapper({
 
   return (
     <ProductDetailHeroSection
-      product={product as any}
+      product={product}
       category={category}
       subCategory={subCategory}
     />
diff --git a/apps/storefront/src/components/product-detail/sections/ProductDetailSectionsWrapper.tsx b/apps/storefront/src/components/product-detail/sections/ProductDetailSectionsWrapper.tsx
index 86b9c1e..b6a2cc7 100644
--- a/apps/storefront/src/components/product-detail/sections/ProductDetailSectionsWrapper.tsx
+++ b/apps/storefront/src/components/product-detail/sections/ProductDetailSectionsWrapper.tsx
@@ -1,4 +1,3 @@
-import { Suspense } from "react";
 import { fetchQuery } from "convex/nextjs";
 import { notFound } from "next/navigation";
 import { api } from "../../../../../../convex/_generated/api";
diff --git a/apps/storefront/src/components/shop/ShopFilterContent.tsx b/apps/storefront/src/components/shop/ShopFilterContent.tsx
index 4716559..6970f23 100644
--- a/apps/storefront/src/components/shop/ShopFilterContent.tsx
+++ b/apps/storefront/src/components/shop/ShopFilterContent.tsx
@@ -22,16 +22,6 @@ type ShopFilterContentProps = {
   isLoading?: boolean;
 };
 
-const FILTER_SECTION_IDS = [
-  "brand",
-  "tags",
-  "petSize",
-  "ageRange",
-  "specialDiet",
-  "material",
-  "flavor",
-] as const;
-
 export function ShopFilterContent({
   options,
   value,
diff --git a/apps/storefront/src/components/shop/ShopFilterSidebar.tsx b/apps/storefront/src/components/shop/ShopFilterSidebar.tsx
index 79b4968..21ce23e 100644
--- a/apps/storefront/src/components/shop/ShopFilterSidebar.tsx
+++ b/apps/storefront/src/components/shop/ShopFilterSidebar.tsx
@@ -9,7 +9,6 @@ import type { ShopFilterState } from "@/lib/shop/filterState";
  * otherwise renders children (e.g. sub-category links).
  */
 export function ShopFilterSidebar({
-  children,
   className,
   filterOptions,
   filterState,
diff --git a/apps/storefront/src/components/shop/ShopToolbar.tsx b/apps/storefront/src/components/shop/ShopToolbar.tsx
index eee4681..1a2dcb5 100644
--- a/apps/storefront/src/components/shop/ShopToolbar.tsx
+++ b/apps/storefront/src/components/shop/ShopToolbar.tsx
@@ -10,7 +10,6 @@ export function ShopToolbar({
   currentSort,
   onSortChange,
   onOpenFilter,
-  resultCount,
 }: {
   sortOptions: SortOption[];
   currentSort: string;
diff --git a/apps/storefront/src/components/wishlist/WishlistPageView.tsx b/apps/storefront/src/components/wishlist/WishlistPageView.tsx
index 1394ed0..de641f4 100644
--- a/apps/storefront/src/components/wishlist/WishlistPageView.tsx
+++ b/apps/storefront/src/components/wishlist/WishlistPageView.tsx
@@ -15,8 +15,7 @@ import { WishlistSignInPrompt } from "./state/WishlistSignInPrompt";
 export function WishlistPageView() {
   const { isAuthenticated, isLoading: authLoading } = useConvexAuth();
   const { items, isLoading, isEmpty } = useWishlist();
-  const { removeItem, isRemoving, addToCart, isAddingToCart } =
-    useWishlistMutations();
+  const { removeItem, isRemoving, addToCart } = useWishlistMutations();
 
   const [removeTarget, setRemoveTarget] = useState<WishlistItem | null>(null);
   const [removingId, setRemovingId] = useState<string | null>(null);
diff --git a/apps/storefront/src/components/wishlist/state/WishlistEmptyState.tsx b/apps/storefront/src/components/wishlist/state/WishlistEmptyState.tsx
index aac0883..7f06c77 100644
--- a/apps/storefront/src/components/wishlist/state/WishlistEmptyState.tsx
+++ b/apps/storefront/src/components/wishlist/state/WishlistEmptyState.tsx
@@ -1,7 +1,6 @@
 "use client";
 
 import Link from "next/link";
-import { WISHLIST_PATH } from "@/lib/wishlist/constants";
 
 function HeartIcon() {
   return (
diff --git a/apps/storefront/src/lib/checkout/useAddressMutations.ts b/apps/storefront/src/lib/checkout/useAddressMutations.ts
index 3aa4baf..7195ba0 100644
--- a/apps/storefront/src/lib/checkout/useAddressMutations.ts
+++ b/apps/storefront/src/lib/checkout/useAddressMutations.ts
@@ -3,6 +3,7 @@
 import { useMutation } from "convex/react";
 import { useCallback } from "react";
 import { api } from "../../../../../convex/_generated/api";
+import type { Id } from "../../../../../convex/_generated/dataModel";
 import type { AddressFormData } from "./types";
 
 /**
@@ -52,7 +53,7 @@ export function useAddressMutations(): {
       data: Partial<AddressFormData> & { isValidated?: boolean },
     ): Promise<void> => {
       await updateMutation({
-        id: id as any,
+        id: id as Id<"addresses">,
         ...(data.firstName !== undefined && { firstName: data.firstName }),
         ...(data.lastName !== undefined && { lastName: data.lastName }),
         ...(data.phone !== undefined && { phone: data.phone }),
@@ -69,14 +70,14 @@ export function useAddressMutations(): {
 
   const setDefault = useCallback(
     async (id: string): Promise<void> => {
-      await setDefaultMutation({ id: id as any });
+      await setDefaultMutation({ id: id as Id<"addresses"> });
     },
     [setDefaultMutation],
   );
 
   const markValidated = useCallback(
     async (id: string, isValidated: boolean): Promise<void> => {
-      await markValidatedMutation({ id: id as any, isValidated });
+      await markValidatedMutation({ id: id as Id<"addresses">, isValidated });
     },
     [markValidatedMutation],
   );
diff --git a/apps/storefront/src/lib/search/useClickOutside.test.tsx b/apps/storefront/src/lib/search/useClickOutside.test.tsx
index 2c18e74..ab20df3 100644
--- a/apps/storefront/src/lib/search/useClickOutside.test.tsx
+++ b/apps/storefront/src/lib/search/useClickOutside.test.tsx
@@ -17,7 +17,7 @@ describe("useClickOutside", () => {
 
   it("does not call handler when enabled is false", () => {
     const handler = vi.fn();
-    const { result } = renderHook(() => {
+    renderHook(() => {
       const ref = useRef<HTMLDivElement>(document.createElement("div"));
       useClickOutside([ref], handler, false);
       return ref;